(Real™ package™)™ #425
Merged
(Real™ package™)™ #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
real-package
branch
from
8386f99 to
90a0a82
Compare
NullVoxPopuli
force-pushed
the
real-package
branch
from
d216d6c to
224b3c8
Compare
NullVoxPopuli
commented
Mar 4, 2024
NullVoxPopuli
commented
Jun 30, 2024
mkszepp
reviewed
Jun 30, 2024
| "volta": { | ||
| "node": "12.22.3", | ||
| "yarn": "1.22.11" | ||
| "node": "20.11.1", |
There was a problem hiding this comment.
Node is here v20, but in ci scripts v18... maybe its better to hold sync
There was a problem hiding this comment.
good point -- node is actually irrelevant now, so I can clean up CI a bit, let it be defaults.
mkszepp
reviewed
Jun 30, 2024
16 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #345
BREAKING:
Maybe breaking:
Overall output:
A note on the diff:
a type=module packages is more of a real package than a v2 addon (currently) because v2 addons are often CJS masquerading as ESM. When a package.json does not have
type=modulespecified, it's assumed that the.jsextension means "Common JS" / require. This isn't great if we want to be better integrated with broader ecosystem tooling. So, since@ember/stringdoes not depend on any ember APIs, it's actually a great candidate for using real ESM, ahead of auto-import/embroider releasing fixes for ESM "ember-addon" packages. (An ember-addon is a package withember-addonin its keywords list)Where'd the test-app go?
I deleted it. This work is under the assumption that, because we don't use anything from ember, and because vitest knows nothing about ember, some basic unit tests ensure that the package works, and would be compatible with all versions of ember that have ember-auto-import or are using embroider.